Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump lines #2568

Merged
merged 5 commits into from
Apr 18, 2018
Merged

Bump lines #2568

merged 5 commits into from
Apr 18, 2018

Conversation

dy
Copy link
Contributor

@dy dy commented Apr 17, 2018 •
edited
Loading

Fixes #2566.
Hopefully 2048 different traces will be reasonable limitation.

@etpinard
Copy link
Contributor

pro tip @dy : use fixes or any of the other keywords listed here to make PR like this one auto-close related issues. Addresses isn't part of that list.

@etpinard etpinard added bug something broken status: reviewable labels Apr 17, 2018
@etpinard
Copy link
Contributor

Thanks @dy. Is there a way to test this fix without adding a 512 line mock? I'm afraid that this might unnecessarily slow down npm run test-image-gl2d.

@etpinard
Copy link
Contributor

Looks good. 💃

Thanks @dy

@dy dy merged commit 4ed586a into master Apr 18, 2018
@dy dy deleted the missing-lines branch April 18, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dy @etpinard